Takashi Sato wrote:
On Mon, 01 Dec 2008 02:55:15 -0000
[EMAIL PROTECTED] wrote:
Author: pquerna
Date: Sun Nov 30 18:55:14 2008
New Revision: 721952
....
+
+static void *hb_worker(apr_thread_t *thd, void *data)
Don't this need to be APR_THREAD_FUNC?
Fixed in r724090.
+{
+ hb_ctx_t *ctx = (hb_ctx_t *) data;
+ apr_status_t rv;
+
+ apr_pool_t *pool = apr_thread_pool_get(thd);
+ apr_pool_tag(pool, "heartbeat_worker");
+ ctx->status = 0;
The meaning of "status zero" is unclear.
Fixed all of the ctx->status things to use apr_status_t values in r724091.
[cut]
+static const char *cmd_hb_address(cmd_parms *cmd,
+ void *dconf, const char *addr)
+{
+ apr_status_t rv;
+ char *host_str;
+ char *scope_id;
+ apr_port_t port = 0;
+ apr_pool_t *p = cmd->pool;
+ hb_ctx_t *ctx =
+ (hb_ctx_t *) ap_get_module_config(cmd->server->module_config,
+ &heartbeat_module);
+ const char *err = ap_check_cmd_context(cmd, GLOBAL_ONLY);
+
+ if (err != NULL) {
+ return err;
+ }
+
+ ctx->active = 1;
+
+ rv = apr_parse_addr_port(&host_str, &scope_id, &port, addr, p);
cmd->temp_pool is better than cmd->pool.
Fixed up the config code to use the temp pool in r724092.
Thanks,
Paul
