On 12/24/2008 02:09 PM, Jim Jagielski wrote: > > On Dec 23, 2008, at 3:56 PM, Ruediger Pluem wrote: >>> Added: httpd/httpd/trunk/modules/mem/config5.m4 >>> URL: >>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/mem/config5.m4?rev=729059&view=auto >>> >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ===================================================================== >>> --- httpd/httpd/trunk/modules/mem/config5.m4 (added) >>> +++ httpd/httpd/trunk/modules/mem/config5.m4 Tue Dec 23 10:39:56 2008 >>> @@ -0,0 +1,14 @@ >>> +dnl modules enabled in this directory by default >>> + >>> +dnl APACHE_MODULE(name, helptext[, objects[, structname[, default[, >>> config]]]]) >>> + >>> +APACHE_MODPATH_INIT(mem) >>> + >>> +sharedmem_objs="mod_sharedmem.lo sharedmem_util.lo" >>> +APACHE_MODULE(sharedmem, memslot provider that uses shared memory, >>> $sharedmem_objs, , most) >>> +APACHE_MODULE(plainmem, memslot provider that uses plain memory, , , >>> no) >>> + >>> +# Ensure that other modules can pick up slotmem.h >>> +APR_ADDTO(INCLUDES, [-I\$(top_srcdir)/$modpath_current]) >> >> Hm. I think this should be in includes if it is intended to be used by >> other stock modules >> and at least it needs to be copied to includes during installation. >> > > ?? If other modules use this, then the module needs to be enabled > at which point -I is setup to find the required header files.
My point was that if other stock modules intent to use it the header files maybe should be in includes (like httpd.h). Otherwise there might be a surprise that headers from non 3rd party code is taken from more then the current dir and includes. But I have no real strong feelings here. Regards Rüdiger
