Ruediger Pluem wrote:
On 01/05/2009 02:16 PM, Nick Kew wrote:
Ruediger Pluem wrote:
Hm. I am slightly confused here. The documentation states that "abort"
should be
the default behaviour (that is the else branch), but if nothing is set
in the config
onfail defaults to -1 which would cause to get us here (the remove case).
So either the documentation or the code is wrong.
Fixed in r731388, which is included in the backport proposal.
Thanks for reviewing.
IMHO r731388 does not fix my concern. The concern I have is that documentation
and code are contrary on what is the default behaviour if nothing is set.
Aaargh!
OK, my local copy is changed to testing (ctx->dc->onfail == 1).
It seems that got omitted from my commit, so you're right.
Fixing it now!
(the difference arose because the local copy has an experimental
variant in with #ifdef, and I couldn't be arsed to tidy all that up).
--
Nick Kew
