On 01/31/2009 08:53 PM, Roy T. Fielding wrote: > On Jan 31, 2009, at 1:53 AM, Ruediger Pluem wrote: >> This causes the server to crash in case where no r->handler is set >> (e.g. in the case >> of a non existing resource). > > Bummer. I suppose it would be too difficult to fix the couple hundred > places where strcmp is used on r->handler without checking for null.
Plus I bet there are a lot of third party modules whose handlers make the assumption that r->handler != NULL. I am not sure if this is a promised API guarantee, but I guess many rely on it. > No objection to applying the patch, but mod_include uses Done in r739598. I guess we need to find a more suitable place for the DEFAULT_HANDLER_NAME define (and possibly prefix it with AP_). Regards Rüdiger
