On 02/16/2009 02:13 PM, Joe Orton wrote:

> 
> Why is it invalid use of the filtering/buckets API to close the file 
> after sending the FILE-containing brigade up the filter stack?  
> 
> It seems counter-intuitive to me that *anything* you do after the 
> ap_pass_brigade() call should make a difference to what was passed up 
> the filter stack.  But I suppose this is the case; even most of the 
> memory-backed bucket types don't duplicate referenced memory in the 
> setaside method.

I guess this is not needed in most cases and is not done for performance
reasons. But maybe we can change the setaside for file buckets to do
an additional dup on the fd.

> So EOS is a better flush then FLUSH, right?

IMHO no. EOS can cause data to remain in the chain (for optimizing the
pipeline case) whereas FLUSH in almost every case should really get
the buckets processed. Yeah I now the words "almost every case" are bad,
but I know that some filters are an exception from the "almost every case" :-(.

Regards

Rüdiger



Reply via email to