On 24 Mar 2009, at 21:45, Jeff Trawick wrote:
something I'm in a relative hurry to get feedback on is this part:
2. retain data
How can MPMs retain data across unload of the DSO?
s->process->server_pool userdata
won't work as-is because there's no server_rec in the pre_config
hook.
Is there a need for an API here? As opposed to the MPM working with
its own file-scope static variables, for instance?
Proposal: Add ap_set_retained_data(key, value),
ap_get_retained_data(key) APIs
(implementation detail: it will set/get userdata on
pglobal)
Although not necessary, provide ap_get_config_count()
(better name!) to
indicate how many passes of config have completed. (The
interface could be
a global variable, but some third-party module would
inevitably clear it.)
Looks fine, if there is indeed a need for it.
--
Nick Kew
