On Tue, Apr 14, 2009 at 1:16 AM, Nick Kew <[email protected]> wrote:
>
> On 12 Apr 2009, at 16:36, Kevac Marko wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=46827
>>
>> This patch adds ability to the mod_dbd Apache module to execute any
>> SQL statements after DB connection have been established.
>
> Thanks for that. I think it's looking good.
>
> Couple of points:
>
> 1. You've exposed dbd_cfg_t in mod_dbd.h - why?
Yes. Because of line
APR_DECLARE_EXTERNAL_HOOK(dbd, AP, apr_status_t, post_connect,
(apr_pool_t *, dbd_cfg_t *, ap_dbd_t *));
in mod_dbd.h
dbd_dfg_t was defined in mod_dbd.c thus invisible from mod_dbd.h
> 2.
> +DBD_DECLARE_NONSTD(void) ap_dbd_sql_init(server_rec *s, const char *query)
Fixed. It was oversight.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46827
--
Marko Kevac
