On 6 Jul 2009, at 15:51, Guenter Knauf wrote:
Hi Nick, please correct me if I'm worng ....
Unlikely :)
+#include "scoreboard.h"
Erk! If that was missing, I may have committed an incorrect version in the first place. Will have to check.
module AP_MODULE_DECLARE_DATA noloris_module; module AP_MODULE_DECLARE_DATA core_module; @@ -83,7 +84,7 @@ return DONE; } - shm_rec += MAX_ADDR_SIZE; + shm_rec += ADDR_MAX_SIZE;
OK, that was me making a hash of yesterday's update.
for (j = 0; j < thread_limit; ++j) { - ws = ap_get_scoreboard_worker(i, j); + ws = ap_get_scoreboard_worker_from_indexes(i, j);
Ooops. I was evidently working to a 2.2.x API without realising it had been invalidated! (minor rant: that kind of breakage is gratuitous and shouldn't happen)!
- memset(shm_rec, NULL, shm_size); + memset(shm_rec, 0, shm_size);
You're right of course. Thanks for the fixes. -- Nick Kew
