On Thu, 09 Jul 2009 09:06:52 -0500 "William A. Rowe, Jr." <[email protected]> wrote:
> Takashi Sato wrote: > > mod_info's new feature doesn't compile against apr/apr-util 1.3.x > > > > /usr/home/test/httpd-trunk/modules/generators/mod_info.c: In function > > 'show_server_settings': > > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: > > implicit declaration of function 'apu_version_string' > > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: > > format '%s' expects type 'char *', but argument 3 has type 'int' > > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: > > 'APU_VERSION_STRING' undeclared (first use in this function) > > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: (Each > > undeclared identifier is reported only once > > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: for > > each function it appears in.) > > > > Include apu_version.h and this is fixed, but considering APR 2.0..... > > apu_version.h does exist in APR 2.0, so we don't need to care APR version? > > Or we should enclose it with #if APR_MAJOR_VERSION < 2 ? > > +1 for trunk, no need for httpd-2.2 - we will be breaking ABI and API at 2.0 > and won't expect httpd 2.2 to compile against it without significant change. > Thanks, I commited it to trunk (r792570) and update patch for 2.2 (r792576)
