On Mon, Sep 14, 2009 at 09:04:08PM +0200, Ruediger Pluem wrote:
> On 09/14/2009 04:16 PM, jor...@apache.org wrote:
> > + /* Reply syntax per RFC 2428: "229 blah blah (|||port|)" where '|'
> > + * can be any character in ASCII from 33-126, obscurely. Verify
> > + * the syntax. */
> > + p = ap_strchr(reply, '(');
> > + if (p == NULL || !p[0] || !p[1] || p[1] != p[2] || p[1] != p[3]
> > + || p[4] == p[1]) {
>
> Hm. Isn't p[0] always == '(' if p != NULL?
> If yes !p[0] || could go away.
Yes, thanks - http://svn.apache.org/viewvc?view=rev&revision=814792
