fua...@apache.org wrote: > /* Special FTPOption that maps NLST directly to LIST */ > - if (!is_list && (fsc->options & FTP_OPT_NLSTISLIST) || dashl) { > + if ((!is_list && (fsc->options & FTP_OPT_NLSTISLIST)) || dashl) { > is_list = 1; > }
Wouldn't this be if (!is_list && ((fsc->options & FTP_OPT_NLSTISLIST) || dashl)) { as there is no point otherwise? Actually we could drop the !is_list test, considering that forced-override isn't harmful.