On 17.09.2009 20:41, William A. Rowe, Jr. wrote: > [email protected] wrote: >> Author: wrowe >> Date: Thu Sep 17 18:10:49 2009 >> New Revision: 816318 >> >> URL: http://svn.apache.org/viewvc?rev=816318&view=rev >> Log: >> Add the new HAVE_SYS_STAT_H entry > > Before I reroll, Rainer, can you verify this clears up the errors > you observed?
I added a simple typo fix in r816385 just now. With that the feature test succeeds and I can compile and run the module. > You mention Solaris. It is notoriously faulty for demanding headers > in a specific sequence, almost as bad as Windows. Give this a try > and if all works out, I think we are ready 0.9.6. Looks good. There are a few warnings, but they would need more FMT type macros: ftp_util.c: In function 'ftp_direntry_make': ftp_util.c:224: warning: format '%d' expects type 'int', but argument 3 has type 'apr_uid_t' ftp_util.c:225: warning: format '%d' expects type 'int', but argument 3 has type 'apr_gid_t' ftp_util.c:231: warning: format '%d' expects type 'int', but argument 3 has type 'apr_uid_t' ftp_util.c:236: warning: format '%d' expects type 'int', but argument 3 has type 'apr_gid_t' Unfortunately there are no FMT macros for those types, not are there apr_psprintf format characters. I guess we can live with it for a beta. Regards, Rainer
