On 4 Oct 2009, at 11:14, Ruediger Pluem wrote:
From rereading the old discussion back in 2005 I guess it is the
correct
thing to fix the comment in util_filter.h and not to destroy
brigades that
weren't created by us but just to clean them up.
So the ownership of the brigade remains with the creator / caller,
whereas the
ownership of the buckets is transferred (either consume them
directly or put them
safely aside for later consumption).
Good summary.
Regarding adding an apr_brigade_cleanup call to ap_pass_brigade I am
undecided.
Makes sense in principle. +1 for trunk at least, though I'd hesitate
to backport!
--
Nick Kew
