On Dec 28, 2009, at 05:51 , Vincent Bray wrote:
Another point came up while thinking about it: Next time you'll have toexplain that RewriteRule foo bar?x=y [QSD]conflicts and QSD wins (as I read the patch(es)). Dunno if that has to bedone in an apologetic manner, though ;-)That's a good point. I'd prefer to see the query string preserved in that case. So, QSD only has an effect if the rule contains no query string.
This slightly revised patch has the effect described above. That is, the original QS is discarded, but any QS on the target is added on - which would have been the effect if you hadn't used QSD at all. Note also that if you use QSA and QSD at the same time, QSD wins, and the replacement query string is used by itself, rather than appended to the original query string. Here again, it's far from clear what someone would expect, when using both flags.
rewrite.diff
Description: Binary data
-- Rich Bowen [email protected]
