On Fri, 8 Jan 2010, Colm MacCárthaigh wrote:
mod_proxy_http:
via header (should have brackets)
ssl_engine_kernel.c:
error message url (should have brackets)
mod_rewrite:
redirects (should have brackets)
logging (doesn't matter)
SERVER_NAME variable
Redirects should have brackets yes ... but I don't think that it's the
job of the SERVER_NAME variable to anticipate potential use in a url,
it's just a representation of an IPv6 address. Introducing braces
would break reverse DNS lookups, for one thing.
DNS lookups are a valid point. Unless somebody disagrees, I will
leave ap_get_server_name()/SERVER_NAME alone but create a public
ap_get_server_name_for_url() function and use that where
appropriate.
