On 2/5/2010 4:35 PM, Graham Leggett wrote: > All of these modules, including mod_remoteip in trunk, take a piece of > information from a request (a header value typically), and then copies > the value upstream to the parent connection, blowing away the real value > of the IP address.
Look again. It preserves both at the parent connection (to optimize the same-same match between 2 consecutive requests, think pipelining). > This blown away IP address now becomes the IP address for all further > requests on the same connection, which, if they are coming from a load > balancer, are very unlikely to come from the same original client. Certainly not true of mod_remoteip by design. For the duration of the request, the value is replaced. For the subsequent request, the value is reset. See line 252/253; is there a simple bug somewhere or are you speaking from direct observation? > Any comments? Yes, please understand the code you plan to modify before breaking modules. Thank you for looking at this code!
