On Tue, Mar 16, 2010 at 7:29 PM, Stefan Fritsch <[email protected]> wrote: > Hi, > > here is the second version of my patch to allow per-module loglevel > configuration. It's available at: > > http://people.apache.org/~sf/per-module-loglevel-v2/
(another tangent based on a quick browse of your patches) This seems to be the change necessary in most modules: +#define APLOG_MODULE_INDEX access_compat_module.module_index ( BTW, this one seems to be slightly borked: +#define APLOG_MODULE_INDEX optional_hook_import_module=.module_index ) Having access to the module_index from any httpd or module-specific macros invoked in the module is potentially useful for diagnostics other than logging. Also, requiring that macro to be defined in order to log isn't much easier on the module than requiring that macro to be defined in order to be a module at all (since most modules log at one point or another). What about calling it AP_MODULE_INDEX (or maybe AP_MODULE_VAR for addressability to the module structure), and formally requiring it to be defined before the inclusion of SOMETHING.h, with #error generated otherwise? (It wasn't 100% clear to me that APLOG_MODULE_INDEX was an absolute requirement for logging. Is it? from http_log.h: +#ifndef APLOG_MODULE_INDEX +/* will be removed later */ +#define APLOG_MODULE_INDEX APLOG_NO_MODULE +#endif + )
