Re: svn commit: r952724 - /httpd/httpd/trunk/server/log.c

[Stefan Fritsch]

On Tue, 8 Jun 2010, William A. Rowe Jr. wrote:

-1 veto.  This is not the appropriate test for a threaded MPM.
We have ap_mpm_query for this very purpose, please don't continue
to propagate this broken meme!!!

Can you please be more verbose about what exactly you are objecting to? I 
think the check should not be

        result == AP_MPMQ_STATIC

but

        result != AP_MPMQ_NOT_SUPPORTED

Is that what you meant?

On 6/8/2010 11:26 AM, rj...@apache.org wrote:
Author: rjung
Date: Tue Jun  8 16:26:39 2010
New Revision: 952724

URL: http://svn.apache.org/viewvc?rev=952724&view=rev


 #if APR_HAS_THREADS
         {
-            apr_os_thread_t tid = apr_os_thread_current();
-            len += apr_snprintf(errstr + len, MAX_STRING_LEN - len,
-                                ":%pT", &tid);
+            int result;
+
+            if (ap_mpm_query(AP_MPMQ_IS_THREADED, &result) == 0
+                && result == AP_MPMQ_STATIC) {
+                apr_os_thread_t tid = apr_os_thread_current();
+                len += apr_snprintf(errstr + len, MAX_STRING_LEN - len,
+                                    ":tid %pT", &tid);
+            }
         }