On 6/23/2010 5:50 PM, NormW wrote:
>> --- mod_authn_socache.c.orig 2010-06-24 06:47:46.796875000 +1000
>> +++ mod_authn_socache.c 2010-06-24 07:11:34.546875000 +1000
>> @@ -301,11 +301,12 @@
>> * to no-longer-defined memory. Hmmm ...
>> */
>> apr_status_t rv;
>> + const char *key;
>> unsigned char val[MAX_VAL_LEN];
>> unsigned int vallen = MAX_VAL_LEN - 1;
>> authn_cache_dircfg *dcfg = ap_get_module_config(r->per_dir_config,
>>
>> &authn_socache_module);
>> - const char *key = construct_key(r, dcfg->context, user, NULL);
>> + key = construct_key(r, dcfg->context, user, NULL);
>> rv = socache_provider->retrieve(socache_instance, r->server,
>> (unsigned char*)key, strlen(key),
>> val, &vallen, r->pool);
This shouldn't be needed, please retest with only the patch below;
>> @@ -342,11 +343,12 @@
>> const char *realm, char **rethash)
>> {
>> apr_status_t rv;
>> + const char *key;
>> authn_cache_dircfg *dcfg;
>> unsigned char val[MAX_VAL_LEN];
>> unsigned int vallen = MAX_VAL_LEN - 1;
>> dcfg = ap_get_module_config(r->per_dir_config,
>> &authn_socache_module);
>> - const char *key = construct_key(r, dcfg->context, user, realm);
>> + key = construct_key(r, dcfg->context, user, realm);
>> rv = socache_provider->retrieve(socache_instance, r->server,
>> (unsigned char*)key, strlen(key),
>> val, &vallen, r->pool);
This is a C99/C++'ism that needs to be fixed.
> 4. modules\aaa\mod_authn_socache.c seems to have different line endings
> to other source files.
svn propset svn:eol-style native fixes this, although it's better if all
our committers would revisit their auto-props from their
