On Wed, Aug 25, 2010 at 12:14 PM, Ruediger Pluem <[email protected]> wrote: > I guess his comment was more about the macro wrappers and the C99 stuff, > which saves us the function call if we would not log due to the loglevel > currently set. I think this is one aspect of the changes and one were > we might lack a prove that it really improves performance.
Exactly. We changed the prototype for ap_log_rerror and friends, but made it so that it is near-impenetrable to know what changed. The #ifdef DOXYGEN approach I outlined earlier would go a way to make it easier for humans to clearly understand what the altered API is intended to be. -- justin
