On Wed, Sep 22, 2010 at 08:44:50PM -0000, Graham Leggett wrote: > Author: minfrin > Date: Wed Sep 22 20:44:50 2010 > New Revision: 1000211 > > URL: http://svn.apache.org/viewvc?rev=1000211&view=rev > Log: > Make cache_server_conf, cache_enable and cache_disable private. Remove > public prefixes from ap_cache_accept_headers, ap_cache_try_lock and > ap_cache_get_providers.
Global symbols should have ap_ (or some other unique-ish string) prefixes even if they are not part of the public API, to reduce the risk of symbol collisions with third-party libraries. > +++ httpd/httpd/trunk/modules/cache/cache_storage.c Wed Sep 22 20:44:50 2010 > @@ -114,8 +114,8 @@ static int set_cookie_doo_doo(void *v, c > * Take headers from the cache, and overlap them over the existing response > * headers. > */ > -CACHE_DECLARE(void) ap_cache_accept_headers(cache_handle_t *h, request_rec > *r, > - int preserve_orig) > +void cache_accept_headers(cache_handle_t *h, request_rec *r, > + int preserve_orig) ... etc Regards, Joe
