Hi, since we are having coding style discussions already, I have two suggestions, too:
- Mark functions arguments which must not be NULL with the attribute nonnull [1]. Then gcc and statical analysers like clang could presumably issue warnings if NULL is passed to those functions. Of course I don't know if it helps much. But we already use the format and sentinel attributes. - There are many functions that make assumptions about there arguments which are not really documented (this is especially true for not- exported functions). We could make generous use of AP_DEBUG_ASSERT to 'document' these assumptions. It may make some bugs easier do debug, too. What do you think? Cheers, Stefan [1] http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
