Thanks.
I've applied the patch, based on the approval received so far.
I like error messages that are informative and tell you how to fix the
problem.
On Nov 4, 2010, at 2:32 PM, Jim Jagielski wrote:
+1
On Nov 4, 2010, at 12:26 PM, Rich Bowen wrote:
I'd like to make the following change to mod_ssl in 2.2. It's
actually a documentation change, in the sense that it changes an
error message, but I wanted to be sure that there's no strong
objection to the change before I make it. This attempts to avoid
the confusion that happens when you get an error message that
doesn't actually tell you anything useful.
Note: I've also made this change in trunk.
Index: ssl_engine_init.c
===================================================================
--- ssl_engine_init.c (revision 1029506)
+++ ssl_engine_init.c (working copy)
@@ -403,7 +403,7 @@
{
ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
"Illegal attempt to re-initialise SSL for server "
- "(theoretically shouldn't happen!)");
+ "(SSLEngine On should go in the VirtualHost, not
in global scope.)");
ssl_die();
}
}
--
Rich Bowen
[email protected]
--
Rich Bowen
[email protected]