On Sun, Nov 7, 2010 at 9:35 AM, <traw...@apache.org> wrote: > Author: trawick > Date: Sun Nov 7 14:35:21 2010 > New Revision: 1032286 > > URL: http://svn.apache.org/viewvc?rev=1032286&view=rev > Log: > improve wording of some function descriptions > > add explicit "FIXME" to an ancient issue > > remove implicit fixme wording related to mutex use
please have a look at these two issues in particular: > -/* ProxyPassReverse and friends are documented as working inside > +/* FIXME > + * ProxyPassReverse and friends are documented as working inside > * <Location>. But in fact they never have done in the case of > * more than one <Location>, because the server_conf can't see it. > * We need to move them to the per-dir config. > - * Discussed in February: > + * Discussed in February 2005: > * http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=110726027118798&w=2 is this still a problem? is it documented? > @@ -368,12 +369,6 @@ struct proxy_balancer { > int sticky_force:1; /* Disable failover for sticky sessions > */ > int scolonsep:1; /* true if ';' seps sticky session > paths */ > int max_attempts_set:1; > - > - /* XXX: Perhaps we will need the proc mutex too. > - * Altrough we are only using arithmetic operations > - * it may lead to a incorrect calculations. > - * For now use only the thread mutex. > - */ > #if APR_HAS_THREADS > apr_thread_mutex_t *mutex; /* Thread lock for updating lb params */ > #endif AFAICT these are in private memory, so there's no inter-process implication.