On 29/11/2010 21:46, Guenter Knauf wrote: > Hi Steve, > ssl_util_stapling.c issues warnings / breaks when compiled with OSSL 1.0.0; > MSVC > warns: > \modules\ssl\ssl_util_stapling.c(140) : warning C4133: '=' : incompatible > types > - from 'struct stack_st_OPENSSL_STRING *' to 'struct stack_st_STRING *' > C:\buildprep\httpd-2.3.x.10\modules\ssl\ssl_util_stapling.c(142) : warning > C4133: 'function' : incompatible types - from 'struct stack_st_STRING *' to > 'struct stack_st *' > C:\buildprep\httpd-2.3.x.10\modules\ssl\ssl_util_stapling.c(148) : warning > C4133: 'function' : incompatible types - from 'struct stack_st_STRING *' to > 'struct stack_st_OPENSSL_STRING *' > > and my picky CodeWarrior breaks: > Compiling ssl_util_stapling.c > ### mwccnlm Compiler: > # File: ssl_util_stapling.c > # ---------------------------- > # 140: aia = X509_get1_ocsp(x); > # Error: ^ > # illegal implicit conversion from 'struct stack_st_OPENSSL_STRING *' to > # 'struct stack_st_STRING *' > ### mwccnlm Compiler: > # 142: cinf->uri = sk_STRING_pop(aia); > # Error: ^ > # illegal implicit conversion from 'struct stack_st_STRING *' to > # 'struct stack_st *' > ### mwccnlm Compiler: > # 148: X509_email_free(aia); > # Error: ^ > # illegal implicit conversion from 'struct stack_st_STRING *' to > # 'struct stack_st_OPENSSL_STRING *' > > Errors caused tool to abort. > > I think that we had some similar already in the past, and you suggested a > change > which was compatible with both 0.9.8 and 1.0.0 branches, but I cant recall ... > Or do we need to cleanly solve this with some version-depent defines? >
See of the patch for bug #50121 resolves this for you. Steve. -- Dr Stephen N. Henson. Senior Technical/Cryptography Advisor, Open Source Software Institute: www.oss-institute.org OpenSSL Core team: www.openssl.org
