> -----Original Message-----
> From: Graham Leggett
> Sent: Mittwoch, 5. Januar 2011 10:30
> To: [email protected]
> Subject: Re: svn commit: r1055250 - in /httpd/httpd/trunk:
> CHANGES modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c
>
> On 05 Jan 2011, at 9:43 AM, Ruediger Pluem wrote:
> >> /*
> >> * Restore Transfer-Encoding header from
> response if we
> >> saved
> >> * one before and there is none left. We need
> it for the
> >> * ap_http_filter. See above.
> >> */
> >> - if (te && !apr_table_get(rp->headers_in, "Transfer-
> >> Encoding")) {
> >> - apr_table_add(rp->headers_in,
> "Transfer-Encoding",
> >> te);
> >> + if (te && !apr_table_get(backend->r->headers_in,
> >> "Transfer-Encoding")) {
> >> + apr_table_add(backend->r->headers_in, "Transfer-
> >> Encoding", te);
> >
> > Doesn't that mean that we will get entries in backend->r->headers
> > that have been allocated
> > from r->pool instead of backend->r->pool? te is an element from r-
> > >headers_out.
>
> In this case we shouldn't, as apr_table_add() makes a copy of
> te from
> backend->r->pool. If we'd used apr_table_addn(), then it would have
> been yes.
Good catch. I missed that.
Regards
Rüdiger
