> -----Original Message----- > From: Joe Orton > Sent: Freitag, 14. Januar 2011 15:42 > To: [email protected] > Subject: Re: svn commit: r1051468 - in /httpd/httpd/trunk: > CHANGES modules/ssl/ssl_engine_io.c > > On Thu, Jan 13, 2011 at 03:25:22PM +0100, "Plüm, Rüdiger, > VF-Group" wrote: > > Should I commit the patch below now to resolve the issue and address > > your point? > > Once again we are struggling with the ill-defined filtering API :( > > You're proposing here to make the _GETLINE call return a > partial read in > a case where no LF is found. I think most existing callers would > probably cope fine with that, but the wording in util_filter.h is > explicit: > > * (If a potential line is too long or no CRLF is found, > the > * filter may return partial data). > > > i.e. it does not make mention of non-blocking mode. > > So I think it would be best to revert the second half of the > patch and > leave the first half as-is, i.e. patch as below - if this > makes sense to > you also?
Makes sense. Committed as r1059037. > > I've been trying to make a test case which tickles this issue > but have > so far not managed to get a non-blocking GETLINE call with > the filter in > the right state. Have a look at the test case provided in the PR50481. This might be helpful. Regards Rüdiger
