On 13 Feb 2011, at 5:08 PM, Ruediger Pluem wrote:

+/*
+ * invalidate a specific URL entity in all caches
+ *
+ * All cached entities for this URL are removed, usually in
+ * response to a POST/PUT or DELETE.
+ *
+ * This function returns OK if at least one entity was found and
+ * removed, and DECLINED if no cached entities were removed.
+ */
+int cache_invalidate(cache_request_rec *cache, request_rec *r)

Why not adjusting cache_remove_url accordingly? It does nearly the same and
has the same prototype.

Nearly the same, but not enough. cache_remove_url() only takes effect if a previous cached entry was found, while cache_invalidate() is unconditional.

As it turns out, invalidating the entry unconditionally is wrong, as we need to do the invalidation only on 2xx. This means this code needs to be changed, waiting for Roy to confirm the exact behaviour before changing it.

Regards,
Graham
--

Reply via email to