[PATCH] scratch some useless ajp error checking

[Jeff Trawick]

dead simple to me (alloc failures are handled by the abort fn, NULL
parameters are more easily diagnosable with a core)

speak up or say bye bye to that code ;)

Index: modules/proxy/ajp_msg.c
===================================================================
--- modules/proxy/ajp_msg.c     (revision 1074659)
+++ modules/proxy/ajp_msg.c     (working copy)
@@ -506,28 +506,9 @@
 {
     ajp_msg_t *msg = (ajp_msg_t *)apr_pcalloc(pool, sizeof(ajp_msg_t));
 
-    if (!msg) {
-        ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
-                      "ajp_msg_create(): can't allocate AJP message memory");
-        return APR_ENOPOOL;
-    }
-
     msg->server_side = 0;
 
     msg->buf = (apr_byte_t *)apr_palloc(pool, size);
-
-    /* XXX: This should never happen
-     * In case if the OS cannont allocate 8K of data
-     * we are in serious trouble
-     * No need to check the alloc return value, cause the
-     * core dump is probably the best solution anyhow.
-     */
-    if (msg->buf == NULL) {
-        ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
-                      "ajp_msg_create(): can't allocate AJP message memory");
-        return APR_ENOPOOL;
-    }
-
     msg->len = 0;
     msg->header_len = AJP_HEADER_LEN;
     msg->max_size = size;
@@ -545,12 +526,6 @@
  */
 apr_status_t ajp_msg_copy(ajp_msg_t *smsg, ajp_msg_t *dmsg)
 {
-    if (dmsg == NULL) {
-        ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
-                     "ajp_msg_copy(): destination msg is null");
-        return AJP_EINVAL;
-    }
-
     if (smsg->len > smsg->max_size) {
         ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
                      "ajp_msg_copy(): destination buffer too "
Index: modules/proxy/ajp_link.c
===================================================================
--- modules/proxy/ajp_link.c    (revision 1074651)
+++ modules/proxy/ajp_link.c    (working copy)
@@ -24,12 +24,6 @@
     apr_status_t status;
     apr_size_t   length;
 
-    if (sock == NULL) {
-        ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
-                      "ajp_ilink_send(): NULL socket provided");
-        return AJP_EINVAL;
-    }
-
     ajp_msg_end(msg);
 
     length = msg->len;
@@ -83,12 +77,6 @@
     apr_size_t   hlen;
     apr_size_t   blen;
 
-    if (sock == NULL) {
-        ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
-                      "ajp_ilink_receive(): NULL socket provided");
-        return AJP_EINVAL;
-    }
-
     hlen = msg->header_len;
 
     status = ilink_read(sock, msg->buf, hlen);