On Sun, Jun 5, 2011 at 23:44, Stefan Fritsch <s...@sfritsch.de> wrote: > On Tuesday 17 May 2011, Ondřej Surý wrote: >> this is the semi-annual ping to check whether I can find enough >> support to get per request r->document_root implemented in 2.3.x. > > Something like that is now implemented in trunk in > > http://svn.apache.org/viewvc?view=revision&revision=1132494 > > Comments welcome.
Looks good to me, although I think you might have missed few lines where conf->ap_document_root is referenced directly in core.c:ap_core_translate(request_rec *r): https://issues.apache.org/bugzilla/attachment.cgi?id=25843&action=diff#server/core.c_sec2 https://issues.apache.org/bugzilla/attachment.cgi?id=25843&action=diff#server/core.c_sec3 But I don't understand the apache internals so well to tell whether it's not a false positive. O. -- Ondřej Surý <ond...@sury.org>