On 11/08/2011 3:12 PM, Kaspar Brand wrote:
Hi Gün,

perhaps we should just break compilation with a check in mod_ssl like:
#if OPENSSL_VERSION_NUMBER<  0x0090700f
#error mod_ssl requires at least OpenSSL version 0.9.7f!
#endif

That's also fine with me, yes. Generally speaking, are there any rules
for handling this sort of version checks in httpd code (and when
aborting with #error is acceptable)?
No idea if a 'rule' but a search of httpd-trunk *.c for #error shows 12 'samples' that might be worth a look.

(Nit: 0x0090700f is actually 0.9.7, 0.9.7f would be 0x0090706f.)

BTW. I admit that I did only tested compile, not runtime; though if
there are issues introduced with your changes they should come up with
all platforms, or?

I would expect so, yes - as long as OpenSSL behaves the same on NetWare
as on other platforms.

Kaspar
Norm

Reply via email to