[snip]
> mod_negotiation: don't return non-AP_FILTER_ERROR filter return
> values
[snip]
> + rv = ap_pass_brigade(r->output_filters, bb);
> + if (rv != APR_SUCCESS) {
> + if (rv != AP_FILTER_ERROR) {
> + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r,
> + "ap_pass_brigade returned %d", rv);
> + return HTTP_INTERNAL_SERVER_ERROR;
> + }
> + return AP_FILTER_ERROR;
> + }
> + return OK;
It looks like exactly this kind of code would or should be used
all over the place -- maybe we should put that in a function/macro?
[snip]
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: [email protected]
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
