On 04.12.2011 15:38, Jim Jagielski wrote:
On Dec 1, 2011, at 8:35 PM, Gregg L. Smith wrote:
@@ -551,7 +546,7 @@ static int scgi_handler(request_rec *r,
cleanup:
if (backend) {
backend->close = 1; /* always close the socket */
- ap_proxy_release_connection(PROXY_FUNCTION, backend, r->server);
+ ap_proxy_release_connection(__FUNCTION__, backend, r->server);
}
return status;
}
While googling why one of my compilers would error out on this, it revealed
that the __FUNCTION__ macro is C99 and not ANSI nor C89, and for now
westillwant to support C89 AFAIK. I do not remember a go-ahead with C99 code.
Did I miss that?
I consider the above a veto-able change...
I "fixed" it on trunk (r1210124) and backported to 2.4.x (1210125). I
hope Stefan is fine with that.
The string passed to those connection utility functions was used
exclusively as a log prefix. All other proxy protocol modules use their
scheme as the parameter (mostly uppercase) so for consistency I reverted
this (small) part of the commit.
Regards,
Rainer
