On Wednesday 07 December 2011, Kaspar Brand wrote: > These changes aren't doing the right thing, I think... both > ssl_log_ssl_error() and ssl_log_cert_error() are basically wrappers > for ap_log_*(), and are therefore called from various places in > mod_ssl - i.e. the messages triggering them should get different > tags. (Also, in the case of ssl_log_cert_error, the error tag is > currently inserted somewhere in the middle of the message, because > ssl_log_cert_error appends to a message already stored in buf.) > > ssl_log_ssl_error is (virtually?) always called in combination with > ap_log_*, so we might do without a tag for these messages - or > otherwise, modify ssl_log_ssl_error to allow a tag to be passed in, > and then use the same tag in both log calls (?). Finally, as far > as ssl_log_xerror/ssl_log_cxerror/ssl_log_rxerror are concerned, > would it be possible to extend the Coccinelle patch file so that > these are also recognized?
Good point. Fixed/added in r1211680. I have not modified ssl_log_ssl_error() besides removing the tag. It's really only called together with some other log message, so the tag doesn't add any value.
