> > >> > @@ -937,7 +937,7 @@ AP_DECLARE(apr_status_t) ap_fatal_signal > > >> > > > >> > #endif /* NO_USE_SIGACTION */ > > >> > > > >> > - pconf = in_pconf; > > >> > + pconf = pconf; > > >> > parent_pid = my_pid = getpid(); > > >> > > >> Doesn't the parameter name need to be changed back? > > > > > > IMHO not. The definition was synced with what we had in the header > > file. > > > Although this is not required from compiler perspective I prefer > > header and c file > > > in sync on the parameter names as well. > > > > Isn't the global pconf shadowed by the changed parameter name, or > does > > this assignment really do something? > > > AH. Now I see what you mean. Yeah, that should be fixed. So in_pconf > everywhere > (header file, function definition in c file, function body). > I am busy today, so if you like feel free to adjust. >
Found some time. Fixed in r1303827. Regards Rüdiger
