[email protected] wrote:
> Author: jorton
> Date: Wed May 23 15:42:33 2012
> New Revision: 1341905
> 
> URL: http://svn.apache.org/viewvc?rev=1341905&view=rev
> Log:
> suexec: Add support for logging to syslog as an alternative to a
> logfile.
> 
> * support/suexec.c (err_output) [AP_LOG_SYSLOG]: Log to syslog.
>   (main): Close syslog fd if open, before execv.  Add -V output
>   for AP_LOG_SYSLOG.
> 
> * configure.in: Add --with-suexec-syslog argument; allow
>   --without-suexec-logfile to omit definition of AP_LOG_EXEC.
> 
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/configure.in
>     httpd/httpd/trunk/support/suexec.c
> 

> Modified: httpd/httpd/trunk/configure.in
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/configure.in?rev=1341905&r1=1341904&r2=1341905&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/configure.in (original)
> +++ httpd/httpd/trunk/configure.in Wed May 23 15:42:33 2012
> @@ -703,7 +703,24 @@ APACHE_HELP_STRING(--with-suexec-gidmin,
>  
>  AC_ARG_WITH(suexec-logfile,
>  APACHE_HELP_STRING(--with-suexec-logfile,Set the logfile),[
> -  AC_DEFINE_UNQUOTED(AP_LOG_EXEC, "$withval", [SuExec log file] ) ] )
> +  if test "x$withval" = "xyes"; then

Shouldn't that be

if test "x$withval" != "xno" -a "x$withval" != "x"; then

otherwise AP_LOG_EXEC gets only defined if --with-suexec-logfile=yes and not if
--with-suexec-logfile=/someplace/somefile

> +    AC_DEFINE_UNQUOTED(AP_LOG_EXEC, "$withval", [SuExec log file])
> +  fi
> +])
> +
> +AC_ARG_WITH(suexec-syslog,
> +APACHE_HELP_STRING(--with-suexec-syslog,Set the logfile),[
> +  if test $withval = "yes"; then
> +    if test "x${with_suexec_logfile}" != "xno"; then
> +      AC_MSG_NOTICE([hint: use "--without-suexec-logfile 
> --with-suexec-syslog"])
> +      AC_MSG_ERROR([suexec does not support both logging to file and syslog])
> +    fi
> +    AC_CHECK_FUNCS([vsyslog], [], [
> +       AC_MSG_ERROR([cannot support syslog from suexec without vsyslog()])])
> +    AC_DEFINE(AP_LOG_SYSLOG, 1, [SuExec log to syslog])
> +  fi    
> +])
> +
>  
>  AC_ARG_WITH(suexec-safepath,
>  APACHE_HELP_STRING(--with-suexec-safepath,Set the safepath),[
> 

Reply via email to