On Sunday 10 June 2012, Kaspar Brand wrote:
> On 01.06.2012 21:36, [email protected] wrote:
> > Author: sf
> > Date: Fri Jun 1 19:36:37 2012
> > New Revision: 1345319
> >
> > URL: http://svn.apache.org/viewvc?rev=1345319&view=rev
> > Log:
> > Add new directive SSLCompression to disable SSL-level
> > compression.
> >
> > PR: 53219
> > Submitted by: Björn Jacke <bjoern j3e de>, Stefan Fritsch
>
> [...]
>
> > Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_config.c
> > URL:
> > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_e
> > ngine_config.c?rev=1345319&r1=1345318&r2=1345319&view=diff
> > ================================================================
> > ============== ---
> > httpd/httpd/trunk/modules/ssl/ssl_engine_config.c (original) +++
> > httpd/httpd/trunk/modules/ssl/ssl_engine_config.c Fri Jun 1
> > 19:36:37 2012
>
> [...]
> I suggest changing/shortening this to something like:
>
> #ifndef OPENSSL_NO_COMP
> if (sc->compression == FALSE) {
> #ifdef SSL_OP_NO_COMPRESSION
> /* OpenSSL >= 1.0 only */
> SSL_CTX_set_options(ctx, SSL_OP_NO_COMPRESSION);
> #elif OPENSSL_VERSION_NUMBER >= 0x00908000L
> /* workaround for OpenSSL 0.9.8 */
> sk_SSL_COMP_zero(SSL_COMP_get_compression_methods());
> #endif
> }
> #endif
Done with some more clean ups in r1348656.
