Better patch, fixed minor issue after another code review. Thanks Claudio
From: Claudio Caldato (MS OPEN TECH) [mailto:claud...@microsoft.com] Sent: Thursday, August 9, 2012 11:13 AM To: dev@httpd.apache.org Subject: Fix for Windows bug#52476 Please code review the fix and let me know if you find any issue. Attached is the proposed patch for server\mpm\winnt\child.c Summary for code reviewers: If AcceptFilter is 'connect' or 'none', we read data from socket on worker thread. We use blocking recv and assign context->overlapped.Pointer to heap allocated buffer. It is the same procedure as in case of 'AcceptFilter data', but done in worker thread to keep listen thread unblocked. Note: It looks like context with overlapped.Pointer == NULL is not processed correctly in windows version of httpd. It may be related to the fact that winnt_insert_network_bucket() rejects context records with overlapped.Pointer == NULL Please advise on what the next step(s) should be. Thanks Claudio
child.c.patch
Description: child.c.patch
