Hi,
here are 2 obvious fixes against apr.
apr/strings/apr_snprintf.c | 1 -
apr/xml/apr_xml.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
Best regards,
CJ
On 09/14/2012 08:10 PM, Igor Galić wrote:
Hey folks,
over at trafficserver we started looking into running
clang's checkers over our code. Using the momentum, Daniel
and myself rand the checkers over httpd and apr (both from
trunk) as well.
Daniel's checks are ran under FreeBSD/clang 3.0:
http://inhouse.humbedooh.com/clang/2012-09-14-3/
Mine are ran under Fedora and clang 3.2 (trunk):
http://people.apache.org/~igalic/checks/httpd/latest/
So long,
i
Index: xml/apr_xml.c
===================================================================
--- xml/apr_xml.c (revision 1384896)
+++ xml/apr_xml.c (working copy)
@@ -63,7 +63,7 @@
** prefix.
*/
for (; elem; elem = elem->parent) {
- apr_xml_ns_scope *ns_scope = elem->ns_scope;
+ apr_xml_ns_scope *ns_scope;
for (ns_scope = elem->ns_scope; ns_scope; ns_scope = ns_scope->next) {
if (strcmp(prefix, ns_scope->prefix) == 0) {
Index: strings/apr_snprintf.c
===================================================================
--- strings/apr_snprintf.c (revision 1384896)
+++ strings/apr_snprintf.c (working copy)
@@ -100,7 +100,6 @@
arg = -arg;
}
arg = modf(arg, &fi);
- p1 = &buf[NDIG];
/*
* Do integer part
*/
