On Thu, Apr 26, 2012 at 09:44:52PM -0000, [email protected] wrote: > Author: sf > Date: Thu Apr 26 21:44:51 2012 > New Revision: 1331110 > > URL: http://svn.apache.org/viewvc?rev=1331110&view=rev > Log: > Replace use of apr_file_write() with apr_file_write_full() to prevent > incomplete writes. > > Add comments in some places where error handling/logging is missing.
I just saw this in STATUS. I think this isn't right for mod_log_*, which should use a single write() call per log line, and fail in all error case. Using _write_full() means we lose the guarantee of an atomic write. Regards, Joe
