On Wed, 3 Jul 2013, Ruediger Pluem wrote: > [email protected] wrote: > > Author: sf > > Date: Tue Jul 2 11:26:41 2013 > > New Revision: 1498880 > > > > URL: http://svn.apache.org/r1498880 > > Log: > > Replace pre_htaccess hook with more flexible open_htaccess hook > > > > Modified: > > httpd/httpd/trunk/CHANGES > > httpd/httpd/trunk/include/ap_mmn.h > > httpd/httpd/trunk/include/http_config.h > > httpd/httpd/trunk/server/config.c > > httpd/httpd/trunk/server/core.c > > > > > Modified: httpd/httpd/trunk/server/config.c > > URL: > > http://svn.apache.org/viewvc/httpd/httpd/trunk/server/config.c?rev=1498880&r1=1498879&r2=1498880&view=diff > > ============================================================================== > > --- httpd/httpd/trunk/server/config.c (original) > > +++ httpd/httpd/trunk/server/config.c Tue Jul 2 11:26:41 2013 > > > AP_IMPLEMENT_HOOK_RUN_ALL(int, header_parser, > > @@ -172,8 +172,11 @@ AP_IMPLEMENT_HOOK_RUN_FIRST(int, handler > > AP_IMPLEMENT_HOOK_RUN_FIRST(int, quick_handler, (request_rec *r, int > > lookup), > > (r, lookup), DECLINED) > > > > -AP_IMPLEMENT_HOOK_RUN_FIRST(int, pre_htaccess, (request_rec *r, const char > > *filename), > > - (r, filename), DECLINED) > > +AP_IMPLEMENT_HOOK_RUN_FIRST(apr_status_t, open_htaccess, > > + (request_rec *r, const char *dir_name, const > > char *access_name, > > + ap_configfile_t **conffile, const char > > **full_name), > > + (r, dir_name, access_name, conffile, > > full_name), > > + AP_DECLINED) > > Why AP_DECLINED and not just DECLINED?
AP_DECLINED has a value in the range reserved in apr_status_t for user error codes. OTOH, there is no guarantee that DECLINED does not collide with another valid value of apr_status_t. So DECLINED for int, AP_DECLINED for apr_status_t. Cheers, Stefan
