On 13 Sep 2013, at 3:00 AM, Eric Covener <[email protected]> wrote: > Can anyone contrast these two and/or comment the callback structure in > mod_cache.h? > > In 2.4, It looks like mod_disk_cache's remove_url() callback does not > close open file descriptors. I think those are normally closed by > some indirect aspect of the file buckets' pool going out of scope -- > but they need to be closed prior to the unlink() on windows.
To be as performant as possible the cache should release anything it holds open as soon as possible, so if it is not explicitly closing these open file descriptors ASAP we should be. Ideally this should have used a subpool, however I left performance improvements to after we'd achieved full RFC compliance from the Co-Advisor test suite (which we now have in trunk). Regards, Graham --
