> -----Original Message----- > From: Graham Leggett [mailto:minf...@sharp.fm] > Sent: dinsdag 19 november 2013 18:44 > To: dev@httpd.apache.org > Subject: Re: [Patch] non blocking writes in core > > On 18 Nov 2013, at 1:24 PM, "Plüm, Rüdiger, Vodafone Group" > <ruediger.pl...@vodafone.com> wrote: > > > + rv = send_brigade_nonblocking(net->client_socket, bb, > > + &(ctx->bytes_written), c); > > + if (APR_STATUS_IS_EAGAIN(rv)) { > > + setaside_remaining_output(f, ctx, bb, c); > > + } > > + else if (rv != APR_EAGAIN) { > > > > What if rv is APR_SUCCESS? > > This is indeed broken, fixed.
This also breaks unsafe for platforms where there are multiple EAGAIN values, like on Windows where APR_STATUS_IS_EAGAIN() returns true for quite a few error codes. Bert