On Thu, Dec 12, 2013 at 11:34 AM, William A. Rowe Jr.
<[email protected]> wrote: On Wed, 04 Dec 2013 11:25:32 -0800
Mike Rumph <[email protected]> wrote:
> > While researching mod_remoteip to work on httpd bugs 55635 and
> > I noticed a few unrelated blemishes in mod_remoteip.c.
> > These include some redundant code and comment typos.
>
> @@ -198,7 +198,7 @@
> while (!(ap_cfg_getline(lbuf, MAX_STRING_LEN, cfp))) {
> args = lbuf;
> while (*(arg = ap_getword_conf(cmd->temp_pool, &args)) !=
> '\0') {
> - if (*arg == '#' || *arg == '\0') {
> + if (*arg == '#') {
> break;
> }
> errmsg = proxies_set(cmd, cfg, arg);
>
> Why are you eliminating a one byte-test bypass of empty lines?
Never mind, I'm clear now, I see where the while condition did that
work.
