On 03/28/2014 09:29 PM, Ruediger Pluem wrote:
>
> Why this check if we already use t->r->pool above :-)?
>
>> + ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, t->r,
>> + APLOGNO(02614) "mod_lua: Value for '%s' in table '%s'
>> contains newline!",
>> + key, t->n);
>> + }
>> + apr_table_set(t->t, key, replacement);
>> + }
>> + else {
>> + apr_table_set(t->t, key, val);
>> }
>> - apr_table_set(t, key, val);
>> return 0;
>> }
>
> Regards
>
> Rüdiger
>
Brain fart, apologies :)
Since we're already NOT fixing up any table called 'notes', we have no
need to check if t->r is set, since it will only be NULL in the (super
secret, hidden) connection notes table.
Thanks for spotting this!
With regards,
Daniel.
