Hi,
I've gone quickly thru the module and I have a few remarks:
- What is the use of FN_LOG_MARK on line 87? Couldn't we use
APLOG_MARK instead?
'connect_to_peer' is called only in one place with
module_index=APLOG_MODULE_INDEX
- Do things like AP_MODULE_MAGIC_AT_LEAST(20130702,2) on line 186
and 228 are meaningful?
I mean, is there a link between the value of
MODULE_MAGIC_NUMBER_MAJOR on trunk and on stable branch?
Should patches related to 'ap_log_rdata' be merged first?
- Maybe temp_pool in 'req_rsp' could be kept till the end of the
function and table 'vars' (line 784) allocated from there ?
CJ
Le 05/04/2014 01:44, [email protected] a écrit :
Author: trawick
Date: Fri Apr 4 23:44:32 2014
New Revision: 1584941
URL: http://svn.apache.org/r1584941
Log:
mod_authnz_fcgi...
Modified:
httpd/httpd/branches/2.4.x/STATUS
Modified: httpd/httpd/branches/2.4.x/STATUS
URL:
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1584941&r1=1584940&r2=1584941&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Fri Apr 4 23:44:32 2014
@@ -239,6 +239,11 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
2.4.x patch: trunk works (modulo CHANGES)
+1: ylavic
+ * Merge mod_authnz_fcgi from trunk.
+
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authnz_fcgi.c
+
http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_authnz_fcgi.xml
+ +1: trawick
+
OTHER PROPOSALS
* A list of further possible backports can be found at:
