On Tue, Apr 15, 2014 at 9:15 PM,  <[email protected]> wrote:
> Author: jim
> Date: Tue Apr 15 19:15:02 2014
> New Revision: 1587695
>
> URL: http://svn.apache.org/r1587695
> Log:
> Merge r1546759, r1546760 from trunk:
>
> Add suspend_connection and resume_connection hooks to notify modules
> when the thread/connection relationship changes.  (Currently implemented
> only for the Event MPM; should be implemented for all async MPMs.)

When I tested and voted for this feature, my ./configure was using
--enable-exception-hook.
With a fresh new build, without this option, compilation fails with :

mpm_common.c: In function ‘ap_hook_suspend_connection’:
mpm_common.c:113: error: ‘struct <anonymous>’ has no member named
‘link_suspend_connection’
[...]
mpm_common.c: In function ‘ap_hook_resume_connection’:
mpm_common.c:116: error: ‘struct <anonymous>’ has no member named
‘link_resume_connection’

Sorry to not have caught this before...

Probably the following patch should be applied too (ie. declare the
links when AP_ENABLE_EXCEPTION_HOOK is 0) :

Index: server/mpm_common.c
===================================================================
--- server/mpm_common.c    (revision 1588240)
+++ server/mpm_common.c    (working copy)
@@ -88,6 +88,8 @@
     APR_HOOK_LINK(mpm_get_name)
     APR_HOOK_LINK(end_generation)
     APR_HOOK_LINK(child_status)
+    APR_HOOK_LINK(suspend_connection)
+    APR_HOOK_LINK(resume_connection)
 )
 #endif
 AP_IMPLEMENT_HOOK_RUN_ALL(int, monitor,
[END]

Regards,
Yann.

Reply via email to