On 02.06.2014 20:49, Ruediger Pluem wrote: > Joe Orton wrote: >> On Wed, May 28, 2014 at 10:10:16PM +0200, Ruediger Pluem wrote: >>> Thanks, but I missed some stuff during review: >>> >>> 1. We don't need to have two DH pointers in make_dh_params >> >> Doh! >> >>> 2. There possible frees on NULL pointers in free_dh_params: >> >> This is unnecessary because DH_free() does that already, but that >> deserves a comment too. I'll fix this with your patch for (1) shortly, >> thanks! >> > > Are you waiting for any action from my side? Just want to avoid that we wait > for each other and deadlock :-)
Just a quick reminder... I think it's important to backport r1597349/r1598107 + the additional adjustment for 2.4.10 (happy to vote once it's settled on trunk). Kaspar
