On Thu, Jun 19, 2014 at 1:39 PM, Yann Ylavic <[email protected]> wrote:
> On Thu, Jun 19, 2014 at 6:36 PM, Jeff Trawick <[email protected]> wrote: > > On Mon, Jun 16, 2014 at 4:26 PM, <[email protected]> wrote: > >> > >> Author: ylavic > >> Date: Mon Jun 16 20:26:24 2014 > >> New Revision: 1602989 > >> > >> URL: http://svn.apache.org/r1602989 > >> Log: > >> mod_proxy: Don't limit the size of the connectable Unix Domain Socket > >> paths. > >> Since connect() to UDS path is used at several places, introduce > >> ap_proxy_connect_uds() in proxy_util. > >> > > > > mod_authnz_fcgi could use something like this when adding Unix socket > > support... (so maybe a core API?) Maybe I'll get a chance to experiment > > before this gets merged to the 2.4.x branch. > > > > It seems weird that proxy_fdpass's original implementation of the > function > > had the timeout handling logic, but the module did not set a timeout for > the > > socket (bad). I guess that should be fixed in proxy_fdpass. > > I first wanted to add some core helpers and use them in mod_cgid too > (didn't notice mod_authnz_fcgi was concerned with its APR_UNSPEC). > But the timeout handling difference made me limit that to > ap_proxy_connect_uds() only (and as a result put the connect in the > function too)... > > The ideal would be to do that in APR though (where the code looks > buggy too), and then use the apr_sockaddr_t where needed in httpd. > Actually I'm working on a that APR patch, however what if APR is > "fixed" on that point, do we still need the workaround in httpd for > the ones using an older APR lib that used to work (eg. with mod_cgid)? > IMO 2.4.x should keep compatibility with APR 1.5.x for quite a while. (Event already requires 1.5.x.) Hopefully there will be a period of time which isn't so short when a lot of people that want to try 2.4.latest can use distro-provided support libraries. -- Born in Roswell... married an alien... http://emptyhammock.com/ http://edjective.org/
