Hi Rainer,
On 23.07.2014 12:18, Rainer Jung wrote:
Good point. But in this case even after dropping the check, it would
mean the build would error out because PCRE_DUPNAMES isn't known. So
then you would have to check the (new) info in the docs, that minimum
PCRE version is 6.7.
I meant to keep this check (which you removed with 1612921) ...
Of course an #error message would help because it is more explicit, but
I think that's not how the code currently is structured in general. If
there is a dependency for a library version, we don't check in the
sources whether the right version is available.
not true - we do; f.e. from mod_ssl_ct.c:
#include "apr_version.h"
#if !APR_VERSION_AT_LEAST(1,5,0)
#error mod_ssl_ct requires APR 1.5.0 or later! (for apr_escape.h)
#endif
and:
#if OPENSSL_VERSION_NUMBER < 0x10002001L
#error "mod_ssl_ct requires OpenSSL 1.0.2-beta1 or later"
#endif
and I'm sure there are many more similar places ...
but I think the check should directly happen after pcre.h is included
and not in the middle of code; see 1612945.
Günter.
